Skip to content

chore(eslint-plugin): [prefer-nullish-coalescing] removed forceSuggestionFixer option #5835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2022
Merged

chore(eslint-plugin): [prefer-nullish-coalescing] removed forceSuggestionFixer option #5835

merged 1 commit into from
Oct 24, 2022

Conversation

adnanhashmi09
Copy link
Contributor

PR Checklist

Overview

Removed forceSuggestionFixer from the code since the rule prefer-nullish-coalescing is not fixable anymore, i.e, it won't fix automatically on someone running --fix. Which makes this option useless.

@nx-cloud
Copy link

nx-cloud bot commented Oct 16, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 65c72b9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 24 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @adnanhashmi09!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Oct 16, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 65c72b9
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/634c026e2094c1000852888d
😎 Deploy Preview https://deploy-preview-5835--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@adnanhashmi09
Copy link
Contributor Author

@JoshuaKGoldberg Please review the PR. Some of the tests are failing, but when I run the tests locally yarn test they pass without any problem.

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Oct 16, 2022
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@JoshuaKGoldberg JoshuaKGoldberg enabled auto-merge (squash) October 16, 2022 20:21
@codecov
Copy link

codecov bot commented Oct 24, 2022 •
edited
Loading

Codecov Report

Merging #5835 (65c72b9) into main (da597c7) will increase coverage by 2.63%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5835      +/-   ##
==========================================
+ Coverage   91.34%   93.98%   +2.63%     
==========================================
  Files         360      148     -212     
  Lines       12010     8083    -3927     
  Branches     3498     2664     -834     
==========================================
- Hits        10971     7597    -3374     
+ Misses        743      273     -470     
+ Partials      296      213      -83
Flag Coverage Δ
unittest 93.98% <ø> (+2.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lint-plugin/src/rules/prefer-nullish-coalescing.ts 100.00% <ø> (ø)
packages/scope-manager/src/lib/scripthost.ts
packages/utils/src/ts-eslint/SourceCode.ts
...s/utils/src/ast-utils/eslint-utils/astUtilities.ts
packages/scope-manager/src/lib/esnext.symbol.ts
packages/scope-manager/src/referencer/Reference.ts
packages/utils/src/ast-utils/misc.ts
...ages/scope-manager/src/lib/es2018.asynciterable.ts
...ges/scope-manager/src/definition/TypeDefinition.ts
packages/utils/src/ts-eslint-scope/index.ts
... and 203 more

@bradzacher bradzacher disabled auto-merge October 24, 2022 02:09
@bradzacher bradzacher merged commit fe80a43 into typescript-eslint:main Oct 24, 2022
@esdrasbrz esdrasbrz mentioned this pull request Oct 26, 2022
Merged
@aaneitchik aaneitchik mentioned this pull request Nov 10, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: [prefer-nullish-coalescing] missing forceSuggestionFixer description
3 participants
@adnanhashmi09 @JoshuaKGoldberg @bradzacher