feat(no-in-array): Disallow using in operator for arrays #5851

mahdi-farnia · 2022-10-20T07:56:58Z

PR Checklist

Addresses an existing open issue: fixes Rule proposal: Ban 'in' operator for arrays #5474
That issue was marked as accepting prs
Steps in CONTRIBUTING.md were taken

Overview

Before:
Error expected because in operator can't be used for checking array values.

const array = [4, 5, 6];

if(4 in array) {
  // ...
}

After:

const array = [4, 5, 6];
// vvv Error: 'in' operator for arrays is forbidden. Use array.indexOf or array.includes instead.
if(4 in array) {
  // ...
}

Closes: #5474

I rewrite it again after one month, and i figured out that the last clone is outdated and i cloned the latest repo and just copied & pasted the file. Because of that there is no history available for this project.

Unnecessary Information Removed Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>

Rule Is Now Off By Default Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>

My bad!😱 Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>

This option is unneeded because users can simply turn off the rule

Support for literal method names & better error message for computed and non-computed method names.

nx-cloud · 2022-10-20T07:57:01Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4e9da68. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 from NxCloud.

typescript-eslint · 2022-10-20T07:57:03Z

Thanks for the PR, @mahdi-farnia!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

netlify · 2022-10-20T07:57:04Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`4e9da68`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6350ff4d1166e400093395ad
😎 Deploy Preview	https://deploy-preview-5851--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

mahdi-farnia · 2022-10-20T08:02:08Z

I have opened another pull request here: #5848

And that PR history comes here too! (I'm not really experienced using github & git)

This shouldn't cause a problem. (should it?)

codecov · 2022-10-20T08:12:13Z

Codecov Report

Merging #5851 (4e9da68) into main (733b359) will increase coverage by 0.00%.
The diff coverage is 92.85%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5851   +/-   ##
=======================================
  Coverage   91.35%   91.35%           
=======================================
  Files         361      363    +2     
  Lines       12024    12066   +42     
  Branches     3499     3513   +14     
=======================================
+ Hits        10984    11023   +39     
  Misses        743      743           
- Partials      297      300    +3

Flag	Coverage Δ
unittest	`91.35% <92.85%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../eslint-plugin/src/rules/call-super-on-override.ts	`90.32% <90.32%> (ø)`
packages/eslint-plugin/src/rules/no-in-array.ts	`100.00% <100.00%> (ø)`

JoshuaKGoldberg · 2022-10-20T13:34:41Z

We don't mind messy Git histories! The commits all get squash merged down to a single merge commit anyway. Git can be excruciatingly difficult system to use for new developers; requiring rewriting history for clean commits is IMO an exclusionary practice.

Can you just delete the unrelated files from this branch? Each PR should only have files that relate to it.

JoshuaKGoldberg · 2022-10-20T14:22:43Z

Also, sorry for the redirect @mahdi-farnia - we realized later on that no-in-array is really a subset of what no-misused-in would cover (#5677). I'm going to close this PR for now, but feel free to send a new one that covers no-misused-in overall.

mahdi-farnia and others added 12 commits October 19, 2022 00:00

Complete Super Method Checking

6ec086d

I rewrite it again after one month, and i figured out that the last clone is outdated and i cloned the latest repo and just copied & pasted the file. Because of that there is no history available for this project.

Update packages/eslint-plugin/docs/rules/call-super-on-override.md

31be88c

Unnecessary Information Removed Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>

Update packages/eslint-plugin/src/rules/call-super-on-override.ts

5138d1d

Rule Is Now Off By Default Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>

Update packages/eslint-plugin/src/rules/call-super-on-override.ts

b8444c3

My bad!😱 Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>

Unnecessary ignoreMethods Option Removed

a31ade2

This option is unneeded because users can simply turn off the rule

Support For Literal Method Names

2b65003

Support for literal method names & better error message for computed and non-computed method names.

Merge branch 'typescript-eslint:main' into main

ab81978

Merge branch 'typescript-eslint:main' into main

1fe9429

Merge remote-tracking branch 'refs/remotes/origin/main'

7f588b3

Merge branch 'typescript-eslint:main' into main

35c527c

Resolve Failed CI Tests & TopLevel Option Removed

e95c87f

Rule no-in-array

4e9da68

JoshuaKGoldberg closed this Oct 20, 2022

JoshuaKGoldberg mentioned this pull request Nov 13, 2022

feat(eslint-plugin): [no-array-delete] add rule #5852

Closed

3 tasks

github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(no-in-array): Disallow using in operator for arrays #5851

feat(no-in-array): Disallow using in operator for arrays #5851

mahdi-farnia commented Oct 20, 2022

nx-cloud bot commented Oct 20, 2022 •

edited

Loading

typescript-eslint bot commented Oct 20, 2022

netlify bot commented Oct 20, 2022 •

edited

Loading

mahdi-farnia commented Oct 20, 2022

codecov bot commented Oct 20, 2022 •

edited

Loading

JoshuaKGoldberg commented Oct 20, 2022

JoshuaKGoldberg commented Oct 20, 2022

feat(no-in-array): Disallow using in operator for arrays #5851

feat(no-in-array): Disallow using in operator for arrays #5851

Conversation

mahdi-farnia commented Oct 20, 2022

PR Checklist

Overview

nx-cloud bot commented Oct 20, 2022 • edited Loading

☁️ Nx Cloud Report

typescript-eslint bot commented Oct 20, 2022

netlify bot commented Oct 20, 2022 • edited Loading

✅ Deploy Preview for typescript-eslint ready!

mahdi-farnia commented Oct 20, 2022

codecov bot commented Oct 20, 2022 • edited Loading

Codecov Report

JoshuaKGoldberg commented Oct 20, 2022

JoshuaKGoldberg commented Oct 20, 2022

nx-cloud bot commented Oct 20, 2022 •

edited

Loading

netlify bot commented Oct 20, 2022 •

edited

Loading

codecov bot commented Oct 20, 2022 •

edited

Loading