Skip to content

feat(website): Add a happy message to playground output pane when no errors or AST (#5868) #5873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 25, 2022
Merged

feat(website): Add a happy message to playground output pane when no errors or AST (#5868) #5873

merged 3 commits into from
Oct 25, 2022

Conversation

sviat9440
Copy link
Contributor

PR Checklist

@nx-cloud
Copy link

nx-cloud bot commented Oct 24, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f7d21f1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @sviat9440!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Oct 24, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit f7d21f1
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6357e84845cfc300094195af
😎 Deploy Preview https://deploy-preview-5873--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

JoshuaKGoldberg
JoshuaKGoldberg reviewed Oct 25, 2022
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for sending!

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@JoshuaKGoldberg JoshuaKGoldberg enabled auto-merge (squash) October 25, 2022 13:44
@codecov
Copy link

codecov bot commented Oct 25, 2022 •
edited
Loading

Codecov Report

Merging #5873 (e8e1518) into main (67744db) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head e8e1518 differs from pull request most recent head f7d21f1. Consider uploading reports for the commit f7d21f1 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5873   +/-   ##
=======================================
  Coverage   91.33%   91.33%           
=======================================
  Files         361      361           
  Lines       12044    12033   -11     
  Branches     3506     3503    -3     
=======================================
- Hits        11000    10990   -10     
+ Misses        748      747    -1     
  Partials      296      296
Flag Coverage Δ
unittest 91.33% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-estree/src/create-program/createProjectProgram.ts 94.28% <0.00%> (+0.80%) ⬆️

@JoshuaKGoldberg JoshuaKGoldberg merged commit c4e0d86 into typescript-eslint:main Oct 25, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Website: Add a happy message to playground output pane when no errors or AST
2 participants
@sviat9440 @JoshuaKGoldberg