-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
docs: add maintainer guide (take two) #5874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add maintainer guide (take two) #5874
Conversation
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@@ -17,6 +17,25 @@ replies: | |||
\ | |||
If you need it sooner, please try the `canary` tag on NPM. | |||
name: Fix Has Been Merged | |||
- body: | | |||
Thanks for the report @<reporter>!\ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm really getting into this extension heh. JoshuaKGoldberg/refined-saved-replies#45
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Me gusta mucho!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pardon my wall of comments—I love making random editorial suggestions as I read.
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
Yeah this is based off of my docs and so far I had only covered bug report issues. Feature requests are something along the lines of:
A lot of the checks here exist to ensure we're not just adding rules or options willy-nilly so that we can keep a lid on the maintenance burden of the project. The TL;DR for the above constraints is just "there has to be a really good and broadly applicable TS-specific usecase for us to add an option or new rule". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few comments but otherwise looking great - thanks for taking this the whole way!
Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
PR Checklist
Overview
Builds off of #5263, including a couple main changes: