fix(eslint-plugin): prefer-readonly-parameter-types] more isTypeReadonly stack overflow handling #5876

sviat9440 · 2022-10-24T21:42:22Z

PR Checklist

Addresses an existing open issue: fixes Bug: [prefer-readonly-parameter-types] isTypeReadonly stack overflow #5875
That issue was marked as accepting prs
Steps in CONTRIBUTING.md were taken

typescript-eslint · 2022-10-24T21:42:24Z

Thanks for the PR, @sviat9440!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

nx-cloud · 2022-10-24T21:42:24Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 338b5b1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 from NxCloud.

netlify · 2022-10-24T21:42:28Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`338b5b1`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/6362ef5d55ae5c0008bd1b20
😎 Deploy Preview	https://deploy-preview-5876--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

codecov · 2022-10-24T22:02:25Z

Codecov Report

Merging #5876 (e22ae8d) into main (f11183c) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head e22ae8d differs from pull request most recent head 338b5b1. Consider uploading reports for the commit 338b5b1 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5876      +/-   ##
==========================================
+ Coverage   91.29%   91.33%   +0.03%     
==========================================
  Files         365      361       -4     
  Lines       12251    12033     -218     
  Branches     3577     3503      -74     
==========================================
- Hits        11185    10990     -195     
+ Misses        758      747      -11     
+ Partials      308      296      -12

Flag	Coverage Δ
unittest	`91.33% <100.00%> (+0.03%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/type-utils/src/isTypeReadonly.ts	`86.00% <100.00%> (ø)`
...lugin-internal/src/rules/plugin-test-formatting.ts	`79.85% <0.00%> (-1.08%)`	⬇️
...-estree/src/create-program/createDefaultProgram.ts	`77.27% <0.00%> (-0.99%)`	⬇️
...ackages/eslint-plugin/src/rules/no-extra-parens.ts	`90.78% <0.00%> (-0.68%)`	⬇️
...es/eslint-plugin/src/rules/no-invalid-void-type.ts	`95.74% <0.00%> (-0.09%)`	⬇️
packages/utils/src/ts-eslint/RuleTester.ts	`100.00% <0.00%> (ø)`
...ges/typescript-estree/src/create-program/shared.ts	`83.33% <0.00%> (ø)`
...pt-estree/src/create-program/createWatchProgram.ts	`78.06% <0.00%> (ø)`
.../src/rules/sort-type-union-intersection-members.ts	`90.74% <0.00%> (ø)`
...escript-estree/src/parseSettings/inferSingleRun.ts
... and 5 more

sviat9440 · 2022-11-02T05:37:03Z

@JoshuaKGoldberg

JoshuaKGoldberg

Super, thanks @sviat9440!

JoshuaKGoldberg · 2022-11-02T22:30:57Z

Normally we ask not to tag us on PRs as we get to them in the queue as soon as we can. But waiting 9 days is quite a bit longer than our normal wait period, sorry about that (this one just slipped through). I wonder if we should add a note in the contributing docs about long PR wait periods. Will ruminate.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | patch | [`5.42.0` -> `5.42.1`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.42.0/5.42.1) | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | patch | [`5.42.0` -> `5.42.1`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.42.0/5.42.1) | --- ### Release Notes <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/eslint-plugin)</summary> ### [`v5.42.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#5421-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5420v5421-2022-11-07) [Compare Source](typescript-eslint/typescript-eslint@v5.42.0...v5.42.1) ##### Bug Fixes - **eslint-plugin:** isTypeReadonly stack overflow ([#5875](typescript-eslint/typescript-eslint#5875)) ([#5876](typescript-eslint/typescript-eslint#5876)) ([2d9a33c](typescript-eslint/typescript-eslint@2d9a33c)) </details> <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/parser)</summary> ### [`v5.42.1`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#5421-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5420v5421-2022-11-07) [Compare Source](typescript-eslint/typescript-eslint@v5.42.0...v5.42.1) **Note:** Version bump only for package [@typescript-eslint/parser](https://github.com/typescript-eslint/parser) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1631 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.42.1` -> `5.43.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.42.1/5.43.0) | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.42.1` -> `5.43.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.42.1/5.43.0) | --- ### Release Notes <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/eslint-plugin)</summary> ### [`v5.43.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#5430-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5421v5430-2022-11-14) [Compare Source](typescript-eslint/typescript-eslint@v5.42.1...v5.43.0) ##### Bug Fixes - **eslint-plugin:** \[no-shadow] handle false positives on generics and parameters ([#5902](typescript-eslint/typescript-eslint#5902)) ([769e8c8](typescript-eslint/typescript-eslint@769e8c8)) - **eslint-plugin:** \[promise-function-async] handle keyword token ([#5907](typescript-eslint/typescript-eslint#5907)) ([f25a94f](typescript-eslint/typescript-eslint@f25a94f)) ##### Features - **eslint-plugin:** \[consistent-type-imports] support fixing to inline types ([#5050](typescript-eslint/typescript-eslint#5050)) ([75dcdf1](typescript-eslint/typescript-eslint@75dcdf1)) - **eslint-plugin:** \[naming-convention] add support for "override" and "async" modifiers ([#5310](typescript-eslint/typescript-eslint#5310)) ([#5610](typescript-eslint/typescript-eslint#5610)) ([c759da1](typescript-eslint/typescript-eslint@c759da1)) - **eslint-plugin:** \[prefer-optional-chain] support suggesting `!foo || !foo.bar` as a valid match for the rule ([#5594](typescript-eslint/typescript-eslint#5594)) ([923d486](typescript-eslint/typescript-eslint@923d486)) #### [5.42.1](typescript-eslint/typescript-eslint@v5.42.0...v5.42.1) (2022-11-07) ##### Bug Fixes - **eslint-plugin:** isTypeReadonly stack overflow ([#5875](typescript-eslint/typescript-eslint#5875)) ([#5876](typescript-eslint/typescript-eslint#5876)) ([2d9a33c](typescript-eslint/typescript-eslint@2d9a33c)) </details> <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/parser)</summary> ### [`v5.43.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#5430-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5421v5430-2022-11-14) [Compare Source](typescript-eslint/typescript-eslint@v5.42.1...v5.43.0) **Note:** Version bump only for package [@typescript-eslint/parser](https://github.com/typescript-eslint/parser) #### [5.42.1](typescript-eslint/typescript-eslint@v5.42.0...v5.42.1) (2022-11-07) **Note:** Version bump only for package [@typescript-eslint/parser](https://github.com/typescript-eslint/parser) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1639 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

fix(eslint-plugin): isTypeReadonly stack overflow (typescript-eslint#…

e22ae8d

…5875)

JoshuaKGoldberg approved these changes Nov 2, 2022

View reviewed changes

Merge branch 'main' into fix/5875

338b5b1

JoshuaKGoldberg enabled auto-merge (squash) November 2, 2022 22:31

JoshuaKGoldberg changed the title ~~fix(eslint-plugin): isTypeReadonly stack overflow (#5875)~~ fix(eslint-plugin): prefer-readonly-parameter-types] more isTypeReadonly stack overflow handling Nov 2, 2022

JoshuaKGoldberg merged commit 2d9a33c into typescript-eslint:main Nov 2, 2022

github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(eslint-plugin): prefer-readonly-parameter-types] more isTypeReadonly stack overflow handling #5876

fix(eslint-plugin): prefer-readonly-parameter-types] more isTypeReadonly stack overflow handling #5876

sviat9440 commented Oct 24, 2022

typescript-eslint bot commented Oct 24, 2022

nx-cloud bot commented Oct 24, 2022 •

edited

Loading

netlify bot commented Oct 24, 2022 •

edited

Loading

codecov bot commented Oct 24, 2022 •

edited

Loading

sviat9440 commented Nov 2, 2022

JoshuaKGoldberg left a comment

JoshuaKGoldberg commented Nov 2, 2022

fix(eslint-plugin): prefer-readonly-parameter-types] more isTypeReadonly stack overflow handling #5876

fix(eslint-plugin): prefer-readonly-parameter-types] more isTypeReadonly stack overflow handling #5876

Conversation

sviat9440 commented Oct 24, 2022

PR Checklist

typescript-eslint bot commented Oct 24, 2022

nx-cloud bot commented Oct 24, 2022 • edited Loading

☁️ Nx Cloud Report

netlify bot commented Oct 24, 2022 • edited Loading

✅ Deploy Preview for typescript-eslint ready!

codecov bot commented Oct 24, 2022 • edited Loading

Codecov Report

sviat9440 commented Nov 2, 2022

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

JoshuaKGoldberg commented Nov 2, 2022

nx-cloud bot commented Oct 24, 2022 •

edited

Loading

netlify bot commented Oct 24, 2022 •

edited

Loading

codecov bot commented Oct 24, 2022 •

edited

Loading