Skip to content

feat(eslint-plugin) [sort-type-union-intersection-members] rename to sort-type-constituents #5879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 27, 2022
Merged

feat(eslint-plugin) [sort-type-union-intersection-members] rename to sort-type-constituents #5879

merged 5 commits into from
Oct 27, 2022

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Oct 25, 2022 •
edited
Loading

PR Checklist

Overview

Directly renames the rule and its messages.

@JoshuaKGoldberg JoshuaKGoldberg added the breaking change This change will require a new major version to be released label Oct 25, 2022
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@nx-cloud
Copy link

nx-cloud bot commented Oct 25, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 03bcb7f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Oct 25, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 03bcb7f
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/635a066aacbfb90008078578
😎 Deploy Preview https://deploy-preview-5879--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review October 25, 2022 14:39
@JoshuaKGoldberg JoshuaKGoldberg changed the base branch from main to v6 October 25, 2022 21:15
@bradzacher bradzacher added this to the 6.0.0 milestone Oct 25, 2022
bradzacher
bradzacher approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: if we wanted to do this now we could actually do it ahead of the v6 release - we'd just need to leave the old name alive for now and mark it as replacedBy

image

@bradzacher bradzacher added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Oct 26, 2022
@JoshuaKGoldberg
Copy link
Member Author

Oh, I forgot about replacedBy! Yes - will do.

@JoshuaKGoldberg JoshuaKGoldberg removed the breaking change This change will require a new major version to be released label Oct 26, 2022
@bradzacher bradzacher removed this from the 6.0.0 milestone Oct 26, 2022
@codecov
Copy link

codecov bot commented Oct 26, 2022 •
edited
Loading

Codecov Report

Merging #5879 (03bcb7f) into main (2ee81df) will decrease coverage by 0.00%.
The diff coverage is 90.74%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5879      +/-   ##
==========================================
- Coverage   91.36%   91.36%   -0.01%     
==========================================
  Files         364      365       +1     
  Lines       12134    12188      +54     
  Branches     3540     3554      +14     
==========================================
+ Hits        11086    11135      +49     
- Misses        748      749       +1     
- Partials      300      304       +4
Flag Coverage Δ
unittest 91.36% <90.74%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/rules/sort-type-union-intersection-members.ts 90.74% <ø> (ø)
.../eslint-plugin/src/rules/sort-type-constituents.ts 90.74% <90.74%> (ø)

bradzacher
bradzacher previously approved these changes Oct 27, 2022
View reviewed changes
@JoshuaKGoldberg JoshuaKGoldberg changed the base branch from v6 to main October 27, 2022 04:17
@JoshuaKGoldberg JoshuaKGoldberg dismissed bradzacher’s stale review October 27, 2022 04:17

The base branch was changed.

@JoshuaKGoldberg JoshuaKGoldberg merged commit a0c8285 into typescript-eslint:main Oct 27, 2022
@JoshuaKGoldberg JoshuaKGoldberg deleted the rename-sort-type-union-intersection-members branch October 27, 2022 05:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher left review comments

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename sort-type-union-intersection-members to sort-type-constituents
2 participants
@JoshuaKGoldberg @bradzacher