Skip to content

fix(eslint-plugin): enable react/jsx-curly-brace-presence lint rule in website package #5894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 27, 2022
Merged

fix(eslint-plugin): enable react/jsx-curly-brace-presence lint rule in website package #5894

merged 2 commits into from
Oct 27, 2022

Conversation

shogohida
Copy link
Contributor

@shogohida shogohida commented Oct 26, 2022 •
edited by JoshuaKGoldberg
Loading

PR Checklist

Overview

@nx-cloud
Copy link

nx-cloud bot commented Oct 26, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a51a1c8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @shogohida!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Oct 26, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit a51a1c8
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/635a11a3e61fea000857c88e
😎 Deploy Preview https://deploy-preview-5894--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@shogohida
Copy link
Contributor Author

shogohida commented Oct 26, 2022 •
edited
Loading

I couldn't run lint locally for some reason so I decided to make a draft pull request to see which code I need to fix after react/jsx-curly-brace-presence is enabled.

Maybe it was because I faced the same issue as below.
eslint/eslint#15785

@shogohida shogohida force-pushed the enable-react/jsx-curly-brace-presence branch from 025fd0c to b1771a1 Compare October 26, 2022 12:39
@shogohida shogohida mentioned this pull request Oct 27, 2022
Closed
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, glad to see no issues were detected here! Thanks for sending this in! ✨

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review October 27, 2022 05:05
@JoshuaKGoldberg JoshuaKGoldberg enabled auto-merge (squash) October 27, 2022 05:05
@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #5894 (b1771a1) into main (67744db) will increase coverage by 0.03%.
The diff coverage is 89.92%.

❗ Current head b1771a1 differs from pull request most recent head a51a1c8. Consider uploading reports for the commit a51a1c8 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5894      +/-   ##
==========================================
+ Coverage   91.33%   91.36%   +0.03%     
==========================================
  Files         361      364       +3     
  Lines       12044    12134      +90     
  Branches     3506     3540      +34     
==========================================
+ Hits        11000    11086      +86     
  Misses        748      748              
- Partials      296      300       +4
Flag Coverage Δ
unittest 91.36% <89.92%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ript-estree/src/create-program/createSourceFile.ts 87.50% <0.00%> (ø)
...t-estree/src/create-program/useProvidedPrograms.ts 84.84% <50.00%> (ø)
...-estree/src/create-program/createDefaultProgram.ts 78.26% <71.42%> (+0.98%) ⬆️
...ges/typescript-estree/src/create-program/shared.ts 83.33% <75.00%> (ø)
...pt-estree/src/create-program/createWatchProgram.ts 78.06% <78.57%> (ø)
...-estree/src/create-program/createProjectProgram.ts 93.47% <81.81%> (ø)
...escript-estree/src/parseSettings/inferSingleRun.ts 90.90% <90.90%> (ø)
...ipt-estree/src/parseSettings/warnAboutTSVersion.ts 93.33% <93.33%> (ø)
...pt-estree/src/parseSettings/createParseSettings.ts 96.82% <96.82%> (ø)
packages/typescript-estree/src/ast-converter.ts 100.00% <100.00%> (ø)
... and 1 more

@JoshuaKGoldberg JoshuaKGoldberg merged commit 344322a into typescript-eslint:main Oct 27, 2022
@shogohida
Copy link
Contributor Author

Thanks for merging! Your support helped me a lot. I hope to contribute more so see you next time!

@shogohida shogohida deleted the enable-react/jsx-curly-brace-presence branch October 27, 2022 05:18
@bradzacher
Copy link
Member

cc @JoshuaKGoldberg - PR naming.
-> used fix instead of chore
-> package namespace was eslint-plugin instead of being empty

It showed up in the release logs!

@JoshuaKGoldberg
Copy link
Member

Oh dangit sorry! I keep messing up on this 😞

@shogohida
Copy link
Contributor Author

Oops, sorry for my mistakes 😞 I will make a PR more carefully when I contribute next time

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Enable react/jsx-curly-brace-presence lint rule in website package
3 participants
@shogohida @bradzacher @JoshuaKGoldberg