feat(utils): add RuleTester API for top-level dependency constraints
#5896
Conversation
|
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5896 +/- ##
==========================================
- Coverage 91.35% 91.32% -0.04%
==========================================
Files 365 365
Lines 12199 12212 +13
Branches 3560 3564 +4
==========================================
+ Hits 11144 11152 +8
- Misses 749 752 +3
- Partials 306 308 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
packages/utils/tests/eslint-utils/rule-tester/RuleTester.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
Overview
As I continued working on #5573, I realised that there are some plugin rules that won't ever work on old versions of TS.
For example
consistent-type-importshard requires at least TS 4.1 as that was the first version where the required syntax was added.This PR adds a new API to the rule tester that allows you to list a set of dependency constraints for all tests in the rule tester constructor. If the constraints don't pass then absolutely no tests are run.