Skip to content

docs(eslint-plugin): [consistent-type-imports] make a note about parserOptions.emitDecoratorMetadata #5904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 31, 2022

Conversation

bradzacher
Copy link
Member

PR Checklist

Overview

Makes a note about the required config in the rule's docs so that it's clearer for users.

@bradzacher bradzacher added the documentation Documentation ("docs") that needs adding/updating label Oct 30, 2022
@nx-cloud
Copy link

nx-cloud bot commented Oct 30, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 37dfb4a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 46 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Oct 30, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 37dfb4a
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/635f6c79a7e9e700099cb4ff
😎 Deploy Preview https://deploy-preview-5904--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@bradzacher bradzacher merged commit 1f14c03 into main Oct 31, 2022
@bradzacher bradzacher deleted the bradzacher-patch-20221030 branch October 31, 2022 10:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: [consistent-type-imports] False positive when using DI and decorators (tsyringe)
3 participants