-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat: bump minimum supported TS version to 4.2.4 #5915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BREAKING CHANGE: Bumps the minimum supported range and removes handling for old versions. Ref #1752
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v6 #5915 +/- ##
==========================================
+ Coverage 91.44% 91.69% +0.25%
==========================================
Files 355 355
Lines 12058 12009 -49
Branches 3530 3518 -12
==========================================
- Hits 11026 11012 -14
+ Misses 733 701 -32
+ Partials 299 296 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
- We _generally_ do not officially support the `rc` releases. | ||
- We endeavour to support the latest stable TypeScript versions as soon as possible after the release. | ||
|
||
Generally we will begin working on supporting the next release when the `rc` version is released. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this decision documented anywhere? Now that we have more maintainer funding & people, it'd be nice to be able to support RC releases. But that's really hard and I'm guessing still not something worth it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm all for us bumping versions and allowing RCs if we're able to - I just don't want us to set the expectation that we will support all RCs.
Sometimes releases are massive and and can take a lot of work to fully support.
Sometimes they have literally no impact for us.
Sometimes features from the beta get dropped from the RC.
Sometimes features from the RC get dropped from the full release.
There's just a lot of variability and with our limited bandwidth I don't want us to commit to anything!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love to see all this code removal! Once the lints are fixed, 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful!
…88d5-46b5-9d0a-3dbe579e8788.png 
BREAKING CHANGE:
Bumps the minimum supported range and removes handling for old versions
PR Checklist
Overview
DT hasn't bumped to 4.2 yet, but it's only just ticked to november, so I'd expect them to do it soon - likely before we do the major release.
This PR: