fix(eslint-plugin)!: remove "isTypescriptFile". #594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #594 +/- ##
==========================================
+ Coverage 94.41% 94.45% +0.03%
==========================================
Files 113 113
Lines 4711 4705 -6
Branches 1293 1288 -5
==========================================
- Hits 4448 4444 -4
Misses 150 150
+ Partials 113 111 -2
|
|
@bradzacher Sorry, I considered to pass the CodeCov, but I did not know what to do. Should probably I add some tests? |
bradzacher
previously approved these changes
Jun 10, 2019
JamesHenry
previously requested changes
Jun 20, 2019
packages/eslint-plugin/src/rules/explicit-member-accessibility.ts
Outdated
Show resolved
Hide resolved
|
Just the one update, then we can merge this. Thanks @sosukesuzuki! |
bradzacher
approved these changes
Jul 20, 2019
JamesHenry
approved these changes
Jul 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
Resolve #524
Remove isTypescriptFile to make some typescript-eslint rules compate with files are not .ts or .tsx(e.g. .vue).