Skip to content

docs: use consistent auto-fixable rule emoji #5966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bmish
Copy link
Contributor

@bmish bmish commented Nov 10, 2022

PR Checklist

Overview

The typescript rules index uses the wrench 🔧 emoji for auto-fixable rules, as do MANY other ESLint plugins (including many that use eslint-doc-generator):

However, the typescript rule doc notice was using an inconsistent emoji 🛠 for the same intended auto-fixable meaning. I am fixing that inconsistency.

@nx-cloud
Copy link

nx-cloud bot commented Nov 10, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ba16f79. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 46 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bmish!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Nov 10, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit ba16f79
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/636f973b38d64b00079833b3
😎 Deploy Preview https://deploy-preview-5966--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bmish bmish changed the title Use consistent auto-fixable rule emoji docs: use consistent auto-fixable rule emoji Nov 11, 2022
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂. 👍 🙏

@JoshuaKGoldberg JoshuaKGoldberg enabled auto-merge (squash) November 12, 2022 12:52
@JoshuaKGoldberg JoshuaKGoldberg merged commit 1b8f9ce into typescript-eslint:main Nov 12, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants