Skip to content

chore(website): [prefer-nullish-coalescing] explicit notice for strictNullChecks #5988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 14, 2022
Merged

chore(website): [prefer-nullish-coalescing] explicit notice for strictNullChecks #5988

merged 2 commits into from
Nov 14, 2022

Conversation

cparros
Copy link
Contributor

@cparros cparros commented Nov 14, 2022 •
edited by JoshuaKGoldberg
Loading

PR Checklist

Overview

This PR adds a line to the prefer-nullish-coalescing docs letting the reader know the rule will not work as intended if strict-null-checks is not enabled.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @cparros!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloud bot commented Nov 14, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 1fd102e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Nov 14, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 1fd102e
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/63726447def2690008ed0c84
😎 Deploy Preview https://deploy-preview-5988--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JoshuaKGoldberg JoshuaKGoldberg changed the title chore(website): [prefer-nullish-coalescing] explicit notice for stric… chore(website): [prefer-nullish-coalescing] explicit notice for strictNullChecks Nov 14, 2022
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯, thanks for this @cparros!

@JoshuaKGoldberg JoshuaKGoldberg enabled auto-merge (squash) November 14, 2022 15:52
@JoshuaKGoldberg JoshuaKGoldberg merged commit ceddb34 into typescript-eslint:main Nov 14, 2022
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Nov 16, 2022
Closed
4 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: [prefer-nullish-coalescing] doesn't work with strictNullChecks: false.
2 participants
@cparros @JoshuaKGoldberg