Skip to content

chore: removed eslint@6 fallbacks for rule messages, and a snapshot #6041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2022
Merged

chore: removed eslint@6 fallbacks for rule messages, and a snapshot #6041

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions packages/eslint-plugin/src/rules/no-invalid-this.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,7 @@ export default createRule<Options, MessageIds>({
recommended: false,
extendsBaseRule: true,
},
// TODO: this rule has only had messages since v7.0 - remove this when we remove support for v6
messages: baseRule.meta.messages ?? {
unexpectedThis: "Unexpected 'this'.",
},
messages: baseRule.meta.messages,
hasSuggestions: baseRule.meta.hasSuggestions,
schema: baseRule.meta.schema,
},
Expand Down
6 changes: 1 addition & 5 deletions packages/eslint-plugin/src/rules/no-unused-expressions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,7 @@ export default util.createRule<Options, MessageIds>({
},
hasSuggestions: baseRule.meta.hasSuggestions,
schema: baseRule.meta.schema,
// TODO: this rule has only had messages since v7.0 - remove this when we remove support for v6
messages: baseRule.meta.messages ?? {
unusedExpression:
'Expected an assignment or function call and instead saw an expression.',
},
messages: baseRule.meta.messages,
},
defaultOptions: [
{
Expand Down
8 changes: 2 additions & 6 deletions packages/eslint-plugin/src/rules/no-useless-constructor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,19 +54,15 @@ export default util.createRule<Options, MessageIds>({
},
hasSuggestions: baseRule.meta.hasSuggestions,
schema: baseRule.meta.schema,
// TODO: this rule has only had messages since v7.0 - remove this when we remove support for v6
messages: baseRule.meta.messages ?? {
noUselessConstructor: 'Useless constructor.',
},
messages: baseRule.meta.messages,
},
defaultOptions: [],
create(context) {
const rules = baseRule.create(context);
return {
MethodDefinition(node): void {
if (
node.value &&
node.value.type === AST_NODE_TYPES.FunctionExpression &&
node.value?.type === AST_NODE_TYPES.FunctionExpression &&
node.value.body &&
checkAccessibility(node) &&
checkParams(node)
Expand Down
5 changes: 1 addition & 4 deletions packages/eslint-plugin/src/rules/quotes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,7 @@ export default util.createRule<Options, MessageIds>({
},
fixable: 'code',
hasSuggestions: baseRule.meta.hasSuggestions,
// TODO: this rule has only had messages since v7.0 - remove this when we remove support for v6
messages: baseRule.meta.messages ?? {
wrongQuotes: 'Strings must use {{description}}.',
},
messages: baseRule.meta.messages,
schema: baseRule.meta.schema,
},
defaultOptions: [
Expand Down
6 changes: 1 addition & 5 deletions packages/eslint-plugin/src/rules/semi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,7 @@ export default util.createRule<Options, MessageIds>({
fixable: 'code',
hasSuggestions: baseRule.meta.hasSuggestions,
schema: baseRule.meta.schema,
// TODO: this rule has only had messages since v7.0 - remove this when we remove support for v6
messages: baseRule.meta.messages ?? {
missingSemi: 'Missing semicolon.',
extraSemi: 'Extra semicolon.',
},
messages: baseRule.meta.messages,
},
defaultOptions: [
'always',
Expand Down