Skip to content

test(typescript-estree): split up parse #6049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

test(typescript-estree): split up parse #6049

wants to merge 5 commits into from

Conversation

Beraliv
Copy link
Contributor

@Beraliv Beraliv commented Nov 20, 2022 •
edited
Loading

PR Checklist

Overview

Performance runs

Split parse.test.ts test to be more paralleliseable. I made following groups as separate files:

  1. moduleResolver
  2. projectFolderIgnoreList
  3. invalid project error messages
  4. preserveNodeMaps
  5. rest of tests
  • Hardware: MacBook Air (M1, 2020), 16 GB memory
  • Software: iTerm2 Build 3.4.18 in MacOS Monterey 12.4 (21F79)
Command Mean [s] Min [s] Max [s] Relative Diff ((main - branch) / main x 100%)
yarn jest parse (no cache, branch) 31.100 ± 0.592 30.681 32.145 1.00 +2.39%
yarn jest parse (with cache, branch) 27.944 ± 0.356 27.346 28.183 1.00 -4.62%
yarn jest parse (no cache, main) 30.375 ± 0.978 29.255 31.468 1.00 0%
yarn jest parse (with cache, main) 29.299 ± 0.360 28.858 29.833 1.00 0%
  • Hardware: MacBook Pro 2.3 GHz 8-Core Intel Core i9, 16 GB 2667 MHz DDR4 memory
  • Software: iTerm2 Build 3.4.18 in MacOS Ventura 13.0 (22A380)
Command Mean [s] Min [s] Max [s] Relative Diff ((main - branch) / main x 100%)
yarn jest parse (no cache, main) 31.185 ± 0.587 30.764 32.221 1.00 0%
yarn jest parse (with cache, main) 29.330 ± 0.059 29.253 29.411 1.00 0%
yarn jest parse (no cache, 5 parse) 27.834 ± 2.477 26.427 32.235 1.00 -10.74%
yarn jest parse (with cache, 5 parse) 24.981 ± 0.684 24.555 26.169 1.00 -14.83%

Commands:

  1. No cache – hyperfine --runs 5 -p "yarn jest --clearCache" "yarn jest parse" --export-markdown performance.md
  2. With cache – hyperfine --runs 5 "yarn jest parse" --export-markdown performance.md

@nx-cloud
Copy link

nx-cloud bot commented Nov 20, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4f4bf68. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @Beraliv!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Nov 20, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 4f4bf68
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/637a82ab3f5a300009368fdf
😎 Deploy Preview https://deploy-preview-6049--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Beraliv Beraliv mentioned this pull request Nov 20, 2022
Closed
@codecov
Copy link

codecov bot commented Nov 20, 2022 •
edited
Loading

Codecov Report

Merging #6049 (4f4bf68) into main (a4f85b8) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6049      +/-   ##
==========================================
- Coverage   91.28%   91.26%   -0.02%     
==========================================
  Files         366      366              
  Lines       12352    12352              
  Branches     3612     3612              
==========================================
- Hits        11275    11273       -2     
- Misses        768      770       +2     
  Partials      309      309
Flag Coverage Δ
unittest 91.26% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...pt-estree/src/create-program/createWatchProgram.ts 77.38% <0.00%> (-1.01%) ⬇️

@Beraliv
Copy link
Contributor Author

Beraliv commented Nov 25, 2022

I will close this PR in favour to another one with a different split

@Beraliv Beraliv closed this Nov 25, 2022
@Beraliv Beraliv mentioned this pull request Nov 25, 2022
Merged
3 tasks
@Beraliv Beraliv deleted the test/parse-parallelisation branch November 25, 2022 09:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Split up parse.test.ts test to be more parallelizeable
1 participant
@Beraliv