Skip to content

chore: use no-restricted-syntax to enforce created options in rules #6074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 24, 2022
Merged

chore: use no-restricted-syntax to enforce created options in rules #6074

merged 5 commits into from
Nov 24, 2022

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Nov 23, 2022 •
edited
Loading

PR Checklist

Overview

Uses no-restricted-syntax to enforce always using create's second parameter, rather than context.options.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloud bot commented Nov 23, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 790a565. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Nov 23, 2022
Closed
@JoshuaKGoldberg JoshuaKGoldberg force-pushed the lint-always-create-options branch from ac0ee9f to ee43230 Compare November 23, 2022 16:06
omril1
omril1 previously approved these changes Nov 23, 2022
View reviewed changes
@bradzacher bradzacher deleted the branch typescript-eslint:main November 24, 2022 00:20
@bradzacher bradzacher closed this Nov 24, 2022
@bradzacher bradzacher reopened this Nov 24, 2022
@bradzacher bradzacher changed the base branch from keyword-spacing-options to main November 24, 2022 00:25
@bradzacher bradzacher dismissed omril1’s stale review November 24, 2022 00:25

The base branch was changed.

@bradzacher
Copy link
Member

man GH did something fucky there. The PR targetted the branch in #6073. When I closed the PR the branch was deleted so it closed this PR and i had to undelete the branch to be able to change the PR target.

that was weird

bradzacher
bradzacher previously approved these changes Nov 24, 2022
View reviewed changes
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review November 24, 2022 02:39
@netlify
Copy link

netlify bot commented Nov 24, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 790a565
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/637fc5863b4f74000a93ace3
😎 Deploy Preview https://deploy-preview-6074--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JoshuaKGoldberg JoshuaKGoldberg changed the title chore: add internal lint rule to always prefer created options chore: use no-restricted-syntax to enforce created options in rules Nov 24, 2022
@JoshuaKGoldberg
Copy link
Member Author

Huh, that is weird. It used to retarget the PR nicely :(

@JoshuaKGoldberg JoshuaKGoldberg merged commit ee62b0b into typescript-eslint:main Nov 24, 2022
@JoshuaKGoldberg JoshuaKGoldberg deleted the lint-always-create-options branch November 24, 2022 19:39
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Nov 25, 2022
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher left review comments

@omril1 omril1 omril1 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Add lint rule to prefer create's second parameter over context.options
3 participants
@JoshuaKGoldberg @bradzacher @omril1