-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
chore: add action to enforce semantic-pr titles #6075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I've seen a few PRs recently that haven't had the correct titles. I accidentally merged one that was missing the colon! This PR adds an action that will validate the PR titles match the semantic commit spec using this action: https://github.com/amannn/action-semantic-pull-request
Thanks for the PR, @bradzacher! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
The "subject" must start with a lower-case letter and must not | ||
end with a full-stop. | ||
For PRs that add or change ESLint-plugin rules, you should begin | ||
the title with "[rule-name] " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be nice if this was enforceable too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah it's just hard cos if you're making non-rule-specific changes you don't want to add it - so it's hard to properly enforce.
PR Checklist
Overview
I've seen a few PRs recently that haven't had the correct titles.
I accidentally merged one that was missing the colon!
This PR adds an action that will validate the PR titles match the semantic commit spec using this action:
https://github.com/amannn/action-semantic-pull-request