fix(eslint-plugin): [prefer-optional-chain] collect MetaProperty type #6083
Conversation
|
Thanks for the PR, @YuseiUeno! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6083 +/- ##
=======================================
Coverage 91.27% 91.27%
=======================================
Files 366 366
Lines 12417 12419 +2
Branches 3631 3632 +1
=======================================
+ Hits 11333 11335 +2
Misses 774 774
Partials 310 310
Flags with carried forward coverage won't be shown. Click here to find out more.
|
packages/eslint-plugin/tests/rules/prefer-optional-chain.test.ts
Outdated
Show resolved
Hide resolved
|
I'm late but I fixed it |
There was a problem hiding this comment.
Looks great, thanks for this @YuseiUeno! 🙌
I added a few tests at the end - didn't want to bug you about them, since they're just small edge cases. 😄
|
Thank you for adding test cases :) |
PR Checklist
import.metamember with both the||and!operators #6000Overview
Fix prefer-optional-chain cannot collect MetaProperty type bug