Skip to content

chore(eslint-plugin-tslint): take rule options from create parameter #6089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

Overview

This is showing up as an unchanged file annotation in #6084 [failing action job]:

/home/runner/work/typescript-eslint/typescript-eslint/packages/eslint-plugin-tslint/src/rules/config.ts
Error:   111:9  error  Retrieve options from create's second parameter so that defaultOptions are applied  no-restricted-syntax

I don't know why this wasn't caught in #6074.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloud bot commented Nov 25, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit edd9e4c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Nov 25, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit edd9e4c
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/638069ebf39b430009e69e7e
😎 Deploy Preview https://deploy-preview-6089--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JoshuaKGoldberg JoshuaKGoldberg merged commit d69fdf4 into typescript-eslint:main Nov 25, 2022
@JoshuaKGoldberg JoshuaKGoldberg deleted the chore-eslint-plugin-tslint-context-options-lint branch November 25, 2022 17:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants