Skip to content

feat(eslint-plugin): [no-explicit-any] Add an optional fixer #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 28, 2019
Merged

feat(eslint-plugin): [no-explicit-any] Add an optional fixer #609

merged 10 commits into from
Jun 28, 2019

Conversation

aggmoulik
Copy link
Contributor

Added Fixer #605

@aggmoulik aggmoulik force-pushed the no-explicit-any-fixer branch from 1508ad7 to a5b811a Compare June 11, 2019 20:01
@aggmoulik aggmoulik force-pushed the no-explicit-any-fixer branch from a5b811a to 37d0d51 Compare June 12, 2019 05:48
@aggmoulik
Copy link
Contributor Author

@bradzacher It is having a code-formatting error but I can't understand what is the error.

@bradzacher
Copy link
Member 

$ prettier --list-different "./**/*.{ts,js,json,md}"
packages/eslint-plugin/src/rules/no-explicit-any.ts

This is saying that the file no-explicit-any.ts has not been formatted correctly.

If you run yarn format on your local machine, it'll run prettier for you across the repo.
You can commit and push the changes and it should be all good.

@bradzacher bradzacher changed the title Added Fix for no-explicit-any feat(eslint-plugin): [no-explicit-any] Add a fixer Jun 12, 2019
bradzacher
bradzacher requested changes Jun 12, 2019
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one suggestion.

Thanks for doing this!

@codecov
Copy link

codecov bot commented Jun 15, 2019 •
edited
Loading

Codecov Report

Merging #609 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #609      +/-   ##
==========================================
+ Coverage    94.3%   94.31%   +<.01%     
==========================================
  Files         109      109              
  Lines        4533     4536       +3     
  Branches     1253     1254       +1     
==========================================
+ Hits         4275     4278       +3     
  Misses        148      148              
  Partials      110      110
Impacted Files Coverage Δ
...ackages/eslint-plugin/src/rules/no-explicit-any.ts 100% <100%> (ø) ⬆️

@aggmoulik
Copy link
Contributor Author

@bradzacher can you please review my PR?

@JamesHenry
Copy link
Member

Thanks @moulikcipherX, just a typo fix and a minor language change. I have added them as github suggestions so hopefully you should just be able to commit them directly.

@bradzacher bradzacher added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jun 20, 2019
@aggmoulik
Copy link
Contributor Author

@JamesHenry @bradzacher I have fixed typo errors. Please review it.

bradzacher
bradzacher previously approved these changes Jun 28, 2019
View reviewed changes
@bradzacher bradzacher changed the title feat(eslint-plugin): [no-explicit-any] Add a fixer feat(eslint-plugin): [no-explicit-any] Add an optional fixer Jun 28, 2019
@bradzacher bradzacher merged commit 606fc70 into typescript-eslint:master Jun 28, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JamesHenry JamesHenry JamesHenry requested changes

@bradzacher bradzacher bradzacher left review comments

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aggmoulik @bradzacher @JamesHenry