feat(eslint-plugin): [no-unsafe-enum-comparison] add rule #6107
Conversation
also fixes for codebase
|
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6107 +/- ##
==========================================
+ Coverage 87.34% 87.36% +0.02%
==========================================
Files 384 386 +2
Lines 13147 13190 +43
Branches 3858 3867 +9
==========================================
+ Hits 11483 11524 +41
- Misses 1298 1300 +2
Partials 366 366
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -29,6 +29,7 @@ export = { | |||
| '@typescript-eslint/no-unnecessary-condition': 'warn', | |||
| '@typescript-eslint/no-unnecessary-type-arguments': 'warn', | |||
| '@typescript-eslint/no-unsafe-declaration-merging': 'warn', | |||
| '@typescript-eslint/no-unsafe-enum-comparison': 'warn', | |||
There was a problem hiding this comment.
changing the recommended configs is considered a breaking change
There was a problem hiding this comment.
Ah wait, per https://typescript-eslint.io/linting/configs, strict isn't considered stable. It's not in our "recommended" configs list. 😌
Still filing #6890 just in case.
PR Checklist
Overview
Adds the
no-unsafe-enum-comparisonrule to prevent comparing enum values against literals.Extracted from #6091.
Co-authored-by: @Zamiell