Skip to content

docs: add Rule Deprecations page #6156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 7, 2022
Merged

docs: add Rule Deprecations page #6156

merged 2 commits into from
Dec 7, 2022

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Summarizes how to describe motivations for deprecating a rule & timelines to do so. Uses #6036 as a reference.

@nx-cloud
Copy link

nx-cloud bot commented Dec 2, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3208dd3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Dec 2, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 3208dd3
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6390adb1a1f01e000992e364
😎 Deploy Preview https://deploy-preview-6156--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review December 3, 2022 09:01
bradzacher
bradzacher previously approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

youhavemystamp

@JoshuaKGoldberg @bradzacher
Update docs/maintenance/issues/Rule_Deprecations.md
3208dd3 
Co-authored-by: Brad Zacher <brad.zacher@gmail.com>
@codecov
Copy link

codecov bot commented Dec 7, 2022 •
edited
Loading

Codecov Report

Merging #6156 (3208dd3) into main (bed6356) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6156   +/-   ##
=======================================
  Coverage   91.26%   91.27%           
=======================================
  Files         366      366           
  Lines       12427    12433    +6     
  Branches     3639     3641    +2     
=======================================
+ Hits        11342    11348    +6     
  Misses        774      774           
  Partials      311      311
Flag Coverage Δ
unittest 91.27% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lint-plugin/src/rules/prefer-nullish-coalescing.ts 100.00% <0.00%> (ø)

@JoshuaKGoldberg JoshuaKGoldberg merged commit bcad11b into typescript-eslint:main Dec 7, 2022
@JoshuaKGoldberg JoshuaKGoldberg deleted the docs-rule-deprecations branch December 7, 2022 15:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Maintenance > Deprecating rules
2 participants
@JoshuaKGoldberg @bradzacher