feat(eslint-plugin): [ban-types] Support namespaced type #616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #616 +/- ##
==========================================
+ Coverage 94.31% 94.37% +0.06%
==========================================
Files 109 109
Lines 4536 4535 -1
Branches 1254 1252 -2
==========================================
+ Hits 4278 4280 +2
Misses 148 148
+ Partials 110 107 -3
|
JamesHenry
previously approved these changes
Jun 20, 2019
bradzacher
requested changes
Jun 28, 2019
There was a problem hiding this comment.
The code you've got right now LGTM.
One thing that I would ask is could you please make it ignore the generic.
Unless I'm mistaken, if I do something like:
options = {
'React.Component': { .... }
}
against this code:
class Foo extends React.Component<Props> {}
Then it will not detect it because getText will include the generic.
(If I'm wrong, then just add a test for that case, and we're good to go!)
|
Turned out it works fine with generics. I have added the tests. In short it works because |
bradzacher
approved these changes
Jun 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #135
This pr add support for banning namespaced type, with option like:
{ types: { 'React.FunctionComponent': { message: 'Use React.FC instead', fixWith: 'React.FC', }, }, };