chore: more aggressively clean local dev caches #6197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
JamesHenry
approved these changes
Dec 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Overview
I took another hard look at local build caching w.r.t. #6144 and #6163. I think the issue was that out-of-date files kept getting out of date, most often
packages/types/src/generated/ast-spec.ts. This adds two layers of protection:typespackage, also cleanssrc/generated/inyarn clean: since it's generated similar todist/.yarn cleanin the postinstall script: as a backup precaution to make sure if you've pulled in build/cache changes, to wipe more things that might be out of date now. Ideally Nx should be caching them when the next line'syarn buildruns anyway.I moved the
BaseNodeJSDoc comments to below itstypeas a way to test this. They show up erroneously in the built output so this is a good change anyway. And, #5252 will blow those changes away once v6 lands.