Skip to content

docs(eslint-plugin): update site description of ban-types docs #6209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 30, 2023
Merged

docs(eslint-plugin): update site description of ban-types docs #6209

merged 2 commits into from
Jan 30, 2023

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Dec 13, 2022 •
edited
Loading

PR Checklist

Overview

I missed this in #6079 - the docs for ban-types include a copy & pasted description of the default options.

@nx-cloud
Copy link

nx-cloud bot commented Dec 13, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 18d39cf. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Dec 13, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 18d39cf
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/639cd2eec037270009712a20
😎 Deploy Preview https://deploy-preview-6209--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Dec 13, 2022
Closed
2 tasks
@JoshuaKGoldberg JoshuaKGoldberg force-pushed the fix-ban-types-default-types-docs branch 2 times, most recently from ca317f6 to 3d833ff Compare December 16, 2022 20:19
@bradzacher bradzacher added the documentation Documentation ("docs") that needs adding/updating label Jan 30, 2023
@bradzacher bradzacher merged commit f17d34b into typescript-eslint:main Jan 30, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the fix-ban-types-default-types-docs branch January 30, 2023 12:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

@Josh-Cena Josh-Cena Awaiting requested review from Josh-Cena

Assignees
No one assigned
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [ban-types] Should suggest object, not Record<string, never>
2 participants
@JoshuaKGoldberg @bradzacher