Skip to content

chore: enable eqeqeq internally #6228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 31, 2023
Merged

chore: enable eqeqeq internally #6228

merged 3 commits into from
Jan 31, 2023

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Enables the rule, allowing == null and != null per our existing code style.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloud bot commented Dec 16, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 86e1ab7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 25 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Dec 16, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 86e1ab7
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/639e76e51214a100081f0266
😎 Deploy Preview https://deploy-preview-6228--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Dec 16, 2022
Closed
3 tasks
@codecov
Copy link

codecov bot commented Dec 16, 2022 •
edited
Loading

Codecov Report

Merging #6228 (86e1ab7) into main (9e35ef9) will increase coverage by 0.02%.
The diff coverage is 91.30%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6228      +/-   ##
==========================================
+ Coverage   91.28%   91.31%   +0.02%     
==========================================
  Files         366      366              
  Lines       12445    12445              
  Branches     3645     3644       -1     
==========================================
+ Hits        11361    11364       +3     
+ Misses        773      770       -3     
  Partials      311      311
Flag Coverage Δ
unittest 91.31% <91.30%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ages/eslint-plugin/src/rules/prefer-regexp-exec.ts 100.00% <ø> (ø)
packages/typescript-estree/src/convert.ts 97.13% <0.00%> (ø)
packages/typescript-estree/src/getModifiers.ts 60.86% <0.00%> (ø)
...ackages/eslint-plugin/src/rules/member-ordering.ts 96.13% <50.00%> (ø)
...kages/eslint-plugin/src/rules/naming-convention.ts 81.86% <50.00%> (ø)
...t-plugin/src/rules/adjacent-overload-signatures.ts 95.34% <100.00%> (ø)
packages/eslint-plugin/src/rules/ban-types.ts 100.00% <100.00%> (ø)
packages/eslint-plugin/src/rules/comma-spacing.ts 100.00% <100.00%> (ø)
...gin/src/rules/naming-convention-utils/validator.ts 96.81% <100.00%> (ø)
...ackages/eslint-plugin/src/rules/no-implied-eval.ts 97.05% <100.00%> (ø)
... and 23 more

bradzacher
bradzacher reviewed Dec 17, 2022
View reviewed changes
@bradzacher bradzacher added the repo maintenance things to do with maintenance of the repo, and not with code/docs label Jan 30, 2023
bradzacher
bradzacher approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you wanted to go one step further and clean up our now out-of-style typeof x === 'undefined' checks as part of this - that'd be gr8

https://cs.github.com/typescript-eslint/typescript-eslint?q=%2Ftypeof+.%2B%3F+%5B%21%3D%5D%3D%3D+%27undefined%27%2F

aw_yiss_refactorin

@bradzacher bradzacher added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jan 30, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Jan 31, 2023
Closed
@JoshuaKGoldberg
Copy link
Member Author

👍 filed #6398 as a good-first-issue!

@JoshuaKGoldberg JoshuaKGoldberg merged commit fbe811c into typescript-eslint:main Jan 31, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the eqeqeq branch January 31, 2023 14:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@HolgerJeromin HolgerJeromin HolgerJeromin left review comments

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Enable ESLint's eqeqeq internally
3 participants
@JoshuaKGoldberg @HolgerJeromin @bradzacher