Skip to content

chore(typescript-estree): remove visitor-keys backwards compat export #6242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 30, 2023
Merged

chore(typescript-estree): remove visitor-keys backwards compat export #6242

merged 4 commits into from
Jan 30, 2023

Conversation

JoshuaKGoldberg
Copy link
Member

BREAKING CHANGE:
Remove visitorKeys backwards compat export from typescript-estree

PR Checklist

Overview

Removes the visitorKeys backwards compat export from typescript-estree.

@JoshuaKGoldberg JoshuaKGoldberg added this to the 6.0.0 milestone Dec 17, 2022
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloud bot commented Dec 17, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 05f8e62. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@bradzacher bradzacher added repo maintenance things to do with maintenance of the repo, and not with code/docs breaking change This change will require a new major version to be released labels Jan 30, 2023
@bradzacher
Copy link
Member

resolve ze conflict and :shipit:

@JoshuaKGoldberg JoshuaKGoldberg force-pushed the typescript-estree-no-visitor-keys branch from 50e6bfc to 05f8e62 Compare January 30, 2023 19:56
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #6242 (e0e665f) into v6 (c8c0a14) will increase coverage by 0.03%.
The diff coverage is n/a.

❗ Current head e0e665f differs from pull request most recent head 05f8e62. Consider uploading reports for the commit 05f8e62 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##               v6    #6242      +/-   ##
==========================================
+ Coverage   91.63%   91.66%   +0.03%     
==========================================
  Files         354      354              
  Lines       12202    12199       -3     
  Branches     3583     3581       -2     
==========================================
+ Hits        11181    11182       +1     
  Misses        721      721              
+ Partials      300      296       -4
Flag Coverage Δ
unittest 91.66% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ript-estree/src/create-program/createSourceFile.ts 77.77% <0.00%> (-12.23%) ⬇️
...kages/eslint-plugin/src/rules/naming-convention.ts 81.86% <0.00%> (-0.17%) ⬇️
...ckages/utils/src/eslint-utils/getParserServices.ts 10.00% <0.00%> (ø)
...ges/typescript-estree/src/create-program/shared.ts 83.33% <0.00%> (ø)
...eslint-plugin/src/rules/consistent-type-exports.ts 97.70% <0.00%> (ø)
...slint-plugin/src/rules/no-unnecessary-condition.ts 98.33% <0.00%> (ø)
...-plugin/src/rules/naming-convention-utils/enums.ts 100.00% <0.00%> (ø)
...plugin/src/rules/naming-convention-utils/schema.ts 100.00% <0.00%> (ø)
...lugin-internal/src/rules/plugin-test-formatting.ts 80.92% <0.00%> (+1.15%) ⬆️
...estree/src/create-program/createIsolatedProgram.ts 76.00% <0.00%> (+12.00%) ⬆️

@JoshuaKGoldberg JoshuaKGoldberg merged commit fde95d3 into typescript-eslint:v6 Jan 30, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the typescript-estree-no-visitor-keys branch January 30, 2023 20:05
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Feb 6, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
breaking change This change will require a new major version to be released repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshuaKGoldberg @bradzacher