Skip to content

docs: describe update steps for ESLint, Node, and TypeScript #6251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Nests the docs as a Dependant Version Upgrades page under Versioning. Proposes a slightly different process for TypeScript specifically.

@nx-cloud
Copy link

nx-cloud bot commented Dec 18, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 66708d7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Dec 18, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 66708d7
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/639f80a525537300098731ab
😎 Deploy Preview https://deploy-preview-6251--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.


### ESLint

> The version range of ESLint currently supported is `^6.0.0 || ^7.0.0 || ^8.0.0`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not introduced in this PR, but I strongly suggest using admonitions like :::info instead. Quotes should be used for quotes and not other things.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, an old habit from working in raw Markdown. +1 on the semantics of switching away from quotes. But I do prefer the visual of a quote because admonitions take the extra line to indicate their type.

Screenshot of a Note admonition

Has there been any discussion about making single-line admonitions? My GitHub+Google searching is failing me, but I can make a Discussion if not.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No discussion yet, but IMO it's fine to make the doc page a bit less densely populated :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Josh-Cena what do you think - should we stick with the larger admonitions, or smaller-but-semantically-off quotes? I'll defer to your suggestion 😄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll go with the same quotes as before for now. But once we can use single-line admonitions per facebook/docusaurus#8458 (comment) I would enthusiastically switch us over!

@bradzacher bradzacher added the documentation Documentation ("docs") that needs adding/updating label Jan 30, 2023
@bradzacher bradzacher added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jan 30, 2023
@JoshuaKGoldberg JoshuaKGoldberg merged commit 587bd4e into typescript-eslint:main Jan 30, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the dependant-version-upgrades branch January 30, 2023 20:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Maintenance > new TypeScript versions
3 participants