feat(eslint-plugin): specify which method is unbound and added test case #6281
Conversation
|
Thanks for the PR, @cparros! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6281 +/- ##
=======================================
Coverage 91.26% 91.27%
=======================================
Files 366 366
Lines 12427 12445 +18
Branches 3639 3645 +6
=======================================
+ Hits 11342 11359 +17
+ Misses 774 772 -2
- Partials 311 314 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| errors: [ | ||
| { | ||
| line: 7, | ||
| column: 9, |
There was a problem hiding this comment.
Could you also add the endColumn here too? That way we know it's on the a, not a, b or some other odd range.
| b: () => {}, | ||
| }; | ||
|
|
||
| const { a, b } = values; |
There was a problem hiding this comment.
A couple more test cases come to mind:
const { a: c } = values;const { b, a } = values;
…ase (typescript-eslint#6281) * Unbound-method test case added and specified error location * test case update
PR Checklist
Overview
Specified which destructured method is unbound and causing an error. Also added a test case for this in
unbound-method.test.ts