Skip to content

fix(website): fix typo #6285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 30, 2022
Merged

fix(website): fix typo #6285

merged 1 commit into from
Dec 30, 2022

Conversation

ArtskydJ
Copy link
Contributor

PR Checklist

  • Addresses an existing open issue:
    • Unnecessary, IMO. I'm happy to open one if y'all would like.
  • That issue was marked as accepting prs
    • N/A: no issue opened
  • Steps in CONTRIBUTING.md were taken
    • There aren't exactly steps in there. I skimmed/read the CoC.

Overview

I fixed a typo.

Before:
image

After:
image
(I edited my browser HTML for this screenshot. I don't know if the docs are backed by a server, or built in CI, or if I need to run a manual build.)

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @ArtskydJ!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloud bot commented Dec 29, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 97cb159. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Dec 29, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 97cb159
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/63ae15965e35a9000ab82096
😎 Deploy Preview https://deploy-preview-6285--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ArtskydJ ArtskydJ changed the title Fix typo in docs Fix typo in docs/linting/CONFIGURATIONS.mdx Dec 29, 2022
@ArtskydJ
Copy link
Contributor Author

It appears that the issue is not solved:

https://deploy-preview-6285--typescript-eslint.netlify.app/linting/configs

image

Or for security reasons, the build doesn't run for non-maintainers?

@ArtskydJ ArtskydJ changed the title Fix typo in docs/linting/CONFIGURATIONS.mdx fix(website): fix typo Dec 29, 2022
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Dec 30, 2022
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, no backing issue needed. Thanks for the fix!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 3f8d105 into typescript-eslint:main Dec 30, 2022
@ArtskydJ ArtskydJ deleted the patch-1 branch December 30, 2022 23:57
tapanprakasht pushed a commit to tapanprakasht/typescript-eslint that referenced this pull request Dec 31, 2022
@ArtskydJ @tapanprakasht
fix(website): fix typo (typescript-eslint#6285)
7504fc6 
Fix typo
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArtskydJ @JoshuaKGoldberg