Skip to content

fix(typescript-estree): remove duplicate hash from parserOptions.project complaint #6290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

  • [ ] Addresses an existing open issue: fixes #000 something I just noticed...
  • That issue was marked as accepting prs
  • Steps in CONTRIBUTING.md were taken

Overview

There are two ##s in this error message we give. Turns out that is not allowed for browser hash navigation.

See the typescript-eslint docs for more info: https://typescript-eslint.io/linting/troubleshooting##i-get-errors-telling-me-eslint-was-configured-to-run--however-that-tsconfig-does-not--none-of-those-tsconfigs-include-this-file

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloud bot commented Dec 30, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 329ac0e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Dec 30, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 329ac0e
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/63bf0bbb39515300085c022c
😎 Deploy Preview https://deploy-preview-6290--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review January 11, 2023 19:19
@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team January 11, 2023 19:19
@JoshuaKGoldberg
Copy link
Member Author

Superceded by #6346. 👍

@JoshuaKGoldberg JoshuaKGoldberg deleted the estree-fix-docs-link branch January 17, 2023 20:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant