Skip to content

chore: fix repo linting #6310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2023
Merged

chore: fix repo linting #6310

merged 1 commit into from
Jan 8, 2023

Conversation

JamesHenry
Copy link
Member

When the renovate PR went in which upgraded the major version of eslint-plugin-jest some issues were introduced.

  • valid-expect is triggered by some more unusual, advanced assertion we have, so we can simply ignore it
  • no-jest-import rule was removed by the plugin, so we remove it from our config

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JamesHenry!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloud bot commented Jan 8, 2023

@netlify
Copy link

netlify bot commented Jan 8, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 026d5a1
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/63bb05f495d0d500092f66ca
😎 Deploy Preview https://deploy-preview-6310--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JamesHenry JamesHenry enabled auto-merge (squash) January 8, 2023 18:05
@JoshuaKGoldberg
Copy link
Member

Weird how failures were able to be introduced. #6233 had a clean build. Maybe a caching issue?

@JamesHenry
Copy link
Member Author

@JoshuaKGoldberg I agree, I'll raise this with the Nx team

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JamesHenry JamesHenry merged commit 2bdf48f into main Jan 8, 2023
@JamesHenry JamesHenry deleted the fix-linting branch January 8, 2023 18:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants