-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
chore: fix repo linting #6310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix repo linting #6310
Conversation
Thanks for the PR, @JamesHenry! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Weird how failures were able to be introduced. #6233 had a clean build. Maybe a caching issue? |
@JoshuaKGoldberg I agree, I'll raise this with the Nx team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
When the renovate PR went in which upgraded the major version of
eslint-plugin-jest
some issues were introduced.valid-expect
is triggered by some more unusual, advanced assertion we have, so we can simply ignore itno-jest-import
rule was removed by the plugin, so we remove it from our config