Skip to content

chore(website): reorganized sidebar and header nav a bit #6311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 30, 2023
Merged

chore(website): reorganized sidebar and header nav a bit #6311

merged 3 commits into from
Jan 30, 2023

Conversation

JoshuaKGoldberg
Copy link
Member

Apropos of nothing, I feel slightly positive about this change:

  • Docs encompasses all of docs, not just the Getting Started area
  • I think people generally want to know package Architecture earlier than & more often than Contributing

Thoughts?

@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team January 8, 2023 21:05
@nx-cloud
Copy link

nx-cloud bot commented Jan 8, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 138ff9c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Jan 8, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 138ff9c
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/63d8218c8e46c600081f5622
😎 Deploy Preview https://deploy-preview-6311--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review January 11, 2023 19:10
@bradzacher bradzacher added the repo maintenance things to do with maintenance of the repo, and not with code/docs label Jan 30, 2023
bradzacher
bradzacher previously approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just thinking this today!
It felt a bit weird going via "Getting Started" to get to the maintenance docs.

@bradzacher
Copy link
Member

fix conflict them :shipit: sir

@bradzacher bradzacher added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jan 30, 2023
@codecov
Copy link

codecov bot commented Jan 30, 2023 •
edited
Loading

Codecov Report

Merging #6311 (8cbb427) into main (4b27777) will decrease coverage by 0.10%.
The diff coverage is n/a.

❗ Current head 8cbb427 differs from pull request most recent head 138ff9c. Consider uploading reports for the commit 138ff9c to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6311      +/-   ##
==========================================
- Coverage   91.37%   91.27%   -0.10%     
==========================================
  Files         368      366       -2     
  Lines       12596    12445     -151     
  Branches     3709     3645      -64     
==========================================
- Hits        11509    11359     -150     
  Misses        772      772              
+ Partials      315      314       -1
Flag Coverage Δ
unittest 91.27% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...kages/eslint-plugin/src/rules/naming-convention.ts 81.86% <0.00%> (-0.17%) ⬇️
...s/eslint-plugin/src/rules/prefer-optional-chain.ts 98.63% <0.00%> (-0.04%) ⬇️
packages/eslint-plugin/src/rules/ban-ts-comment.ts 96.96% <0.00%> (ø)
...ckages/eslint-plugin/src/util/getESLintCoreRule.ts 75.00% <0.00%> (ø)
...-plugin/src/rules/naming-convention-utils/enums.ts 100.00% <0.00%> (ø)
...plugin/src/rules/naming-convention-utils/schema.ts 100.00% <0.00%> (ø)
packages/eslint-plugin/src/rules/key-spacing.ts
packages/eslint-plugin/src/util/getStringLength.ts

@JoshuaKGoldberg JoshuaKGoldberg merged commit ca190de into typescript-eslint:main Jan 30, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher left review comments

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshuaKGoldberg @bradzacher