Skip to content

chore(website): link every rule doc to the playground with default config #6317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 10, 2023

Conversation

mhnaeem
Copy link
Contributor

@mhnaeem mhnaeem commented Jan 9, 2023

PR Checklist

Overview

This change includes a link in every rule doc to the playground, clicking on the link opens the playground with default config for the rule already loaded.

The plugin responsible for generating/modifying the rules doc was edited to add a single link referencing to the playground with the default config hashed.

This change includes a link in every rule doc to the playground, clicking on the link opens the playground with default config for the rule already loaded
typescript-eslint#6085
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @mhnaeem!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloud bot commented Jan 9, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 357cbfd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Jan 9, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 357cbfd
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/63e3002beab1030008f2fdef
😎 Deploy Preview https://deploy-preview-6317--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for sending this in @mhnaeem! ✨ Just left a few comments for your review. Let us know what you think & we can get this merged.

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Jan 22, 2023
… pr changes

Changes:

1) Renamed functions and variables to use full work string instead of str
2) Added jsdoc with better explanation for functions
3) Created a new MDXComponent for try in playground link
4) Some formatting and text fixes

typescript-eslint#6085
@mhnaeem
Copy link
Contributor Author

mhnaeem commented Jan 22, 2023

@JoshuaKGoldberg Thank you for your input, I have made all the requested changes. Let me know if something else could be improved.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for sending this in @mhnaeem! I'll apply a couple of touchups now and ship. 🔥

@bradzacher
Copy link
Member

goodjobpotter

@bradzacher bradzacher changed the title feat(website): link every rule doc to the playground with default config chore(website): link every rule doc to the playground with default config Feb 10, 2023
@bradzacher bradzacher merged commit 24fdfc8 into typescript-eslint:main Feb 10, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
awaiting response Issues waiting for a reply from the OP or another party
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement(rule docs): add a quick-link that allows you to open a rule in the playground
3 participants