Skip to content

test: verify that there are no errors on the website #6365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 25, 2023
Merged

test: verify that there are no errors on the website #6365

merged 2 commits into from
Jan 25, 2023

Conversation

Jefiozie
Copy link
Contributor

@Jefiozie Jefiozie commented Jan 22, 2023 •
edited
Loading

PR Checklist

Overview

I've made some small changes to test if there are any errors on the website by listening to the console. Added a second test with the opposite for verification. Happy to improve some more if needed.

@JoshuaKGoldberg I've made the choice not to search for a library as the tests are pretty simple and have no "magic" from the library.

Update: hmm I'm not sure what I'm doing wrong here. On my machine I don't see any issues. Am I'm missing a step if I just run the playwrih test with NX?

@nx-cloud
Copy link

nx-cloud bot commented Jan 22, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5222df7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 25 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @Jefiozie!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Jan 22, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 5222df7
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/63d0e8f82a0162000834d3bc
😎 Deploy Preview https://deploy-preview-6365--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

JoshuaKGoldberg
JoshuaKGoldberg requested changes Jan 22, 2023
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good start! Hope this helps with the debugging, but let me know if not. 🙂

@Jefiozie
Copy link
Contributor Author

Jefiozie commented Jan 24, 2023 •
edited by JoshuaKGoldberg
Loading

hi @JoshuaKGoldberg, I've made the requested changes, thanks for your feedback. I'm not sure why the test on CI keeps failing. Running the website project locally with npx nx test website doesn't return the error that is descibribed in the CI test.
Do you build the website in a different way then the default npx nx build website?

@JoshuaKGoldberg
Copy link
Member

Ooh I do get that error locally from npx nx website start (also when running it as aliased under yarn start)!

Screenshot of Chrome devtools error: 'react-dom.development.js?3c4a:86 Warning: ReactDOM.render is no longer supported in React 18. Use createRoot instead. Until you switch to the new API, your app will behave as if it's running React 17. Learn more: https://reactjs.org/link/switch-to-createroot'

So this PR will have to account for that message. At least until facebook/docusaurus#7264 comes in.

JoshuaKGoldberg
JoshuaKGoldberg requested changes Jan 24, 2023
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes to get a passing build - but hey, nice to know the new test is working! 😄

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Jan 24, 2023
@Jefiozie
Copy link
Contributor Author

So now the test are running for the website check. I'm not sure why the other tests are failing. Is this a known issue in the workflows? If I need to change anything just let me know.

Thanks for the feedback @JoshuaKGoldberg

@JoshuaKGoldberg
Copy link
Member

Huh, I hadn't seen those failures before. Must be a transient issue in GitHub Actions...

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯, thanks for iterating on this @Jefiozie! Great stuff. 😄

@JoshuaKGoldberg JoshuaKGoldberg enabled auto-merge (squash) January 25, 2023 17:30
@JoshuaKGoldberg JoshuaKGoldberg merged commit 033e87c into typescript-eslint:main Jan 25, 2023
@Jefiozie Jefiozie deleted the addErrorCheck branch January 25, 2023 17:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
awaiting response Issues waiting for a reply from the OP or another party
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: End-to-end test that no console errors are logged on the homepage
2 participants
@Jefiozie @JoshuaKGoldberg