Skip to content

chore: test on Node 14 #6400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 31, 2023

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Switches ci.yml to use matrix.node-version, as suggested in #6396 (comment).

Co-authored-by: @bradzacher

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloud bot commented Jan 31, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fda4a7c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Jan 31, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit fda4a7c
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/63d94308e3cbd70008a7fc4e
😎 Deploy Preview https://deploy-preview-6400--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review January 31, 2023 16:35
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stableinfra.gif

@bradzacher bradzacher merged commit f366b6f into typescript-eslint:main Jan 31, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the node-14-testing branch January 31, 2023 20:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repo: Test on Node 14 again
2 participants