Skip to content

fix(eslint-plugin): do not use .at(), Node 14 does not support it #6402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 31, 2023
Merged

fix(eslint-plugin): do not use .at(), Node 14 does not support it #6402

merged 3 commits into from
Jan 31, 2023

Conversation

coyotte508
Copy link
Contributor

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @coyotte508!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloud bot commented Jan 31, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f222453. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Jan 31, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit f222453
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/63d93cb31336340009db88b5
😎 Deploy Preview https://deploy-preview-6402--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@coyotte508 coyotte508 changed the title fix(key-spacing): do not use .at(), Node 14 does not support it fix(eslint-plugin): do not use .at(), Node 14 does not support it Jan 31, 2023
@codecov
Copy link

codecov bot commented Jan 31, 2023 •
edited
Loading

Codecov Report

Merging #6402 (9b91293) into main (fbe811c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 9b91293 differs from pull request most recent head f222453. Consider uploading reports for the commit f222453 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6402   +/-   ##
=======================================
  Coverage   91.38%   91.38%           
=======================================
  Files         368      368           
  Lines       12605    12608    +3     
  Branches     3712     3713    +1     
=======================================
+ Hits        11519    11522    +3     
  Misses        770      770           
  Partials      316      316
Flag Coverage Δ
unittest 91.38% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/key-spacing.ts 99.29% <100.00%> (+0.01%) ⬆️

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JoshuaKGoldberg JoshuaKGoldberg enabled auto-merge (squash) January 31, 2023 16:11
@JoshuaKGoldberg JoshuaKGoldberg merged commit 077ed1b into typescript-eslint:main Jan 31, 2023
@coyotte508 coyotte508 deleted the fix-key-spacing branch January 31, 2023 16:43
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [key-spacing] Crashes on Node 14
2 participants
@coyotte508 @JoshuaKGoldberg