feat(typescript-estree): add type checker wrapper APIs to ParserServicesWithTypeInformation #6404
Conversation
…cesWithTypeInformation
|
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v6 #6404 +/- ##
==========================================
- Coverage 91.87% 91.60% -0.28%
==========================================
Files 359 355 -4
Lines 12400 12155 -245
Branches 3653 3581 -72
==========================================
- Hits 11393 11134 -259
- Misses 703 723 +20
+ Partials 304 298 -6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
PR Checklist
Overview
Adds to
ParserServicesWithTypeInformationthe two most commonly used TypeScript type checking APIs:getSymbolAtLocationandgetTypeAtLocation. Then converts all places in code that I could find that used either after immediately retrieving the TS node for an ES node.Also applies a few standardizations that helped me find-and-replace:
const services = util.getParserServices(context)- not a variable namedparserServices, or variables from{ ... }const checker = services.program.getTypeChecker()- not a variable namedtypeCheckerortypes, and not an intermediateprogramvariableUpdates the Custom Rules docs page to reflect this.