Skip to content

chore(typescript-estree): remove unnecessary babel test exclude #6427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2023
Merged

chore(typescript-estree): remove unnecessary babel test exclude #6427

merged 1 commit into from
Feb 5, 2023

Conversation

JoshuaKGoldberg
Copy link
Member

Overview

Noticed we've since been updated to a version of Babel that supports satisfies.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloud bot commented Feb 5, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 477057d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Feb 5, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 477057d
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/63df49d4fb6a6000092d0e84
😎 Deploy Preview https://deploy-preview-6427--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Feb 5, 2023 •
edited
Loading

Codecov Report

Merging #6427 (477057d) into main (f330e06) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6427   +/-   ##
=======================================
  Coverage   91.52%   91.53%           
=======================================
  Files         371      371           
  Lines       12651    12662   +11     
  Branches     3717     3721    +4     
=======================================
+ Hits        11579    11590   +11     
  Misses        754      754           
  Partials      318      318
Flag Coverage Δ
unittest 91.53% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...int-plugin/src/rules/strict-boolean-expressions.ts 98.90% <0.00%> (+0.06%) ⬆️

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review February 5, 2023 06:26
@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team February 5, 2023 06:26
@JoshuaKGoldberg JoshuaKGoldberg merged commit 3e102fe into typescript-eslint:main Feb 5, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the remove-unnecessary-babel-exclude branch February 5, 2023 06:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoshuaKGoldberg @JamesHenry