Skip to content

test: remove now-unnecessary jest-resolver.js #6429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JoshuaKGoldberg
Copy link
Member

Overview

This used to be necessary. It isn't anymore. 🔪

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloud bot commented Feb 6, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5847871. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Feb 6, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 5847871
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/63e06f5482813c000afc6919
😎 Deploy Preview https://deploy-preview-6429--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review February 6, 2023 03:41
@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team February 6, 2023 03:41
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since the linked issue is closed anyway

@JoshuaKGoldberg JoshuaKGoldberg merged commit cb4d6ac into typescript-eslint:main Feb 6, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the remove-jest-resolver branch February 6, 2023 03:45
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants