Skip to content

chore: check package.json existence in package-packages.ts #6454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Makes sure a package.json file exists in a packages/* directory before requiring the file.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloud bot commented Feb 11, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f3e7d8e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Feb 11, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit f3e7d8e
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/63e7ab59fe94230008e54c4f
😎 Deploy Preview https://deploy-preview-6454--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pi8gng6t6wx61.gif

@bradzacher bradzacher merged commit 766ab1d into typescript-eslint:main Feb 11, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the pack-packages-check-package-json branch February 11, 2023 22:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repo: integration tests fail on an empty package directory
2 participants