Skip to content

docs(website): fix typed rules heading link in custom rule docs #6460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 15, 2023
Merged

docs(website): fix typed rules heading link in custom rule docs #6460

merged 2 commits into from
Feb 15, 2023

Conversation

thilllon
Copy link
Contributor

PR Checklist

Overview

The link is not matching. the link should address https://typescript-eslint.io/custom-rules#type-checking

@thilllon
Update Custom_Rules.mdx
d0edf54 
The link is not matching
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @thilllon!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloud bot commented Feb 13, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2f499f8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Feb 13, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 2f499f8
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/63eceee2385e20000859f17e
😎 Deploy Preview https://deploy-preview-6460--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

JoshuaKGoldberg
JoshuaKGoldberg requested changes Feb 14, 2023
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the typo spot! Just requesting changes to go with a different fix.

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Feb 14, 2023
@thilllon thilllon changed the title Update Custom_Rules.mdx docs(custom rules): update docs Feb 15, 2023
@JoshuaKGoldberg JoshuaKGoldberg changed the title docs(custom rules): update docs docs(website): fix typed rules heading link in custom rule docs Feb 15, 2023
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 725e7f5 into typescript-eslint:main Feb 15, 2023
@thilllon thilllon deleted the patch-1 branch February 15, 2023 15:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
awaiting response Issues waiting for a reply from the OP or another party
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thilllon @JoshuaKGoldberg