fix(typescript-estree): check for relative/root paths in printing file path errors #6491
Conversation
|
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6491 +/- ##
==========================================
- Coverage 90.66% 90.66% -0.01%
==========================================
Files 374 376 +2
Lines 12823 12851 +28
Branches 3777 3783 +6
==========================================
+ Hits 11626 11651 +25
- Misses 853 856 +3
Partials 344 344
Flags with carried forward coverage won't be shown. Click here to find out more.
|
packages/typescript-estree/src/create-program/createProjectProgram.ts
Outdated
Show resolved
Hide resolved
…gram.ts Co-authored-by: Armano <armano2@users.noreply.github.com>
PR Checklist
Overview
Completely eschews
process.cwd()detection (which already wasn't relevant anyway, astsconfigRootDirdefaults toprocess.cwd()!) in favor of checking whether thetsconfigRootDiragainst the printedfilePath.This means that the nice
`<tsconfigRootDir>/`prefix now only shows up when thetsconfigRootDiris a complete starter for the path. Siblings and distance parents will no longer show up.