Skip to content

fix(website): correct crash when switching to dark/light mode in playground #6496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 21, 2023
Merged

fix(website): correct crash when switching to dark/light mode in playground #6496

merged 3 commits into from
Feb 21, 2023

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Feb 20, 2023 •
edited
Loading

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloud bot commented Feb 20, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b73c1a0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Feb 20, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit ae0e3aa
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/63f3cf5d7fd3db000819e813
😎 Deploy Preview https://deploy-preview-6496--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 thanks! This seems cleaner to me.

@codecov
Copy link

codecov bot commented Feb 20, 2023 •
edited
Loading

Codecov Report

Merging #6496 (ae0e3aa) into main (766ab1d) will increase coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6496      +/-   ##
==========================================
+ Coverage   90.61%   90.66%   +0.04%     
==========================================
  Files         372      375       +3     
  Lines       12709    12841     +132     
  Branches     3739     3778      +39     
==========================================
+ Hits        11516    11642     +126     
- Misses        853      854       +1     
- Partials      340      345       +5
Flag Coverage Δ
unittest 90.66% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lugin/src/rules/consistent-generic-constructors.ts 90.69% <0.00%> (-4.18%) ⬇️
...ckages/eslint-plugin/src/util/getESLintCoreRule.ts 75.00% <0.00%> (ø)
packages/eslint-plugin/src/rules/no-mixed-enums.ts 94.44% <0.00%> (ø)
packages/eslint-plugin/src/rules/block-spacing.ts 100.00% <0.00%> (ø)
packages/typescript-estree/src/clear-caches.ts 100.00% <0.00%> (ø)
...-plugin/src/rules/explicit-function-return-type.ts 97.95% <0.00%> (+0.13%) ⬆️
...pt-estree/src/parseSettings/createParseSettings.ts 91.66% <0.00%> (+0.36%) ⬆️
...ipt-estree/src/parseSettings/resolveProjectList.ts 91.48% <0.00%> (+0.37%) ⬆️

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@bradzacher bradzacher added this pull request to the merge queue Feb 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 21, 2023
@bradzacher bradzacher merged commit 3122d6c into main Feb 21, 2023
@bradzacher bradzacher deleted the fix/playground-dark-mode branch February 21, 2023 03:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Playground crashes when switching between light and dark mode
3 participants
@armano2 @JoshuaKGoldberg @bradzacher