Skip to content

fix(website): corect playground build issue #6506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2023
Merged

fix(website): corect playground build issue #6506

merged 1 commit into from
Feb 21, 2023

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Feb 21, 2023 •
edited
Loading

PR Checklist

Overview

exclude newly introduced clear-caches from website-eslint, #6476

Uncaught TypeError: (0 , qz.clearWatchCaches) is not a function

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloud bot commented Feb 21, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 89f5539. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Feb 21, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 89f5539
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/63f416743f5f870008959398
😎 Deploy Preview https://deploy-preview-6506--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@armano2 armano2 changed the title fix(website-eslint): playground eslint build issue fix(website): corect playground build issue Feb 21, 2023
@codecov
Copy link

codecov bot commented Feb 21, 2023 •
edited
Loading

Codecov Report

Merging #6506 (89f5539) into main (cb272f0) will decrease coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6506      +/-   ##
==========================================
- Coverage   90.66%   90.64%   -0.03%     
==========================================
  Files         375      375              
  Lines       12841    12844       +3     
  Branches     3778     3782       +4     
==========================================
  Hits        11642    11642              
- Misses        854      857       +3     
  Partials      345      345
Flag Coverage Δ
unittest 90.64% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/type-utils/src/containsAllTypesByName.ts 0.00% <0.00%> (ø)
.../eslint-plugin/src/rules/promise-function-async.ts 98.07% <0.00%> (ø)

@bradzacher bradzacher added this pull request to the merge queue Feb 21, 2023
Merged via the queue into main with commit 6aad7d3 Feb 21, 2023
@bradzacher bradzacher deleted the fix/website-eslint-exclude-clear-caches branch February 21, 2023 01:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Playground Doesn't Work
2 participants
@armano2 @bradzacher