Skip to content

chore(website): add ESQuery visualizer to playground #6524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 13, 2023

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Feb 23, 2023

PR Checklist

Overview

inspired by https://estools.github.io/esquery/

image

image

image

@nx-cloud
Copy link

nx-cloud bot commented Feb 23, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 88fad1b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 46 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Feb 23, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 88fad1b
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/640b1f9a1a1bf2000701da53
😎 Deploy Preview https://deploy-preview-6524--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@armano2 armano2 changed the title feat(website): add basic esquery visualizer to playground feat(website): add basic ESQuery visualizer to playground Feb 23, 2023
@armano2 armano2 changed the title feat(website): add basic ESQuery visualizer to playground feat(website): add ESQuery visualizer to playground Feb 23, 2023
@armano2 armano2 marked this pull request as ready for review February 24, 2023 19:40
@armano2 armano2 added package: website Issues related to the @typescript-eslint website website: playground labels Feb 25, 2023
@bradzacher bradzacher changed the title feat(website): add ESQuery visualizer to playground chore(website): add ESQuery visualizer to playground Mar 1, 2023
@armano2 armano2 requested a review from bradzacher March 1, 2023 18:15
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Mar 8, 2023
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, love it!

Left a suggestion for simplifying the state & making the UI a bit friendly - but it'd a nice followup good first issue, and I don't think should block.

Comment on lines 10 to 11
-webkit-appearance: none;
-moz-appearance: none;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're good to no longer use these: https://caniuse.com/css-appearance

Suggested change
-webkit-appearance: none;
-moz-appearance: none;

A good followup might be to add Stylelint to our builds, since we've got a good amount of CSS now.

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Mar 8, 2023
@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #6524 (88fad1b) into main (e86802d) will increase coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6524      +/-   ##
==========================================
+ Coverage   90.66%   90.67%   +0.01%     
==========================================
  Files         376      376              
  Lines       12851    12849       -2     
  Branches     3783     3783              
==========================================
  Hits        11651    11651              
+ Misses        856      854       -2     
  Partials      344      344              
Flag Coverage Δ
unittest 90.67% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@bradzacher bradzacher added this pull request to the merge queue Mar 13, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 13, 2023
@JoshuaKGoldberg JoshuaKGoldberg merged commit cb12682 into main Mar 13, 2023
@JoshuaKGoldberg JoshuaKGoldberg deleted the feat/esquery-in-playground branch March 13, 2023 04:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge package: website Issues related to the @typescript-eslint website website: playground
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Website: Add ESQuery visualizer to the playground
3 participants