-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
chore(website): add ESQuery visualizer to playground #6524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR, @armano2! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great, love it!
Left a suggestion for simplifying the state & making the UI a bit friendly - but it'd a nice followup good first issue
, and I don't think should block.
-webkit-appearance: none; | ||
-moz-appearance: none; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're good to no longer use these: https://caniuse.com/css-appearance
-webkit-appearance: none; | |
-moz-appearance: none; |
A good followup might be to add Stylelint to our builds, since we've got a good amount of CSS now.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6524 +/- ##
==========================================
+ Coverage 90.66% 90.67% +0.01%
==========================================
Files 376 376
Lines 12851 12849 -2
Branches 3783 3783
==========================================
Hits 11651 11651
+ Misses 856 854 -2
Partials 344 344
Flags with carried forward coverage won't be shown. Click here to find out more. |
PR Checklist
Overview
inspired by https://estools.github.io/esquery/