Skip to content

chore(website): correct build compilation warning #6527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2023
Merged

chore(website): correct build compilation warning #6527

merged 1 commit into from
Mar 1, 2023

Conversation

armano2
Copy link
Collaborator

@armano2 armano2 commented Feb 24, 2023

PR Checklist

Overview

use default import for json5 package

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloud bot commented Feb 24, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f41a57e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Feb 24, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit f41a57e
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/63f93e6806b6780008bab4f6
😎 Deploy Preview https://deploy-preview-6527--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@armano2 armano2 changed the title chore(website): correct build compilation warning #6424 chore(website): correct build compilation warning Feb 24, 2023
@codecov
Copy link

codecov bot commented Feb 24, 2023 •
edited
Loading

Codecov Report

Merging #6527 (f41a57e) into main (06b96ad) will increase coverage by 0.02%.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6527      +/-   ##
==========================================
+ Coverage   90.64%   90.66%   +0.02%     
==========================================
  Files         375      376       +1     
  Lines       12844    12851       +7     
  Branches     3782     3783       +1     
==========================================
+ Hits        11642    11651       +9     
+ Misses        857      856       -1     
+ Partials      345      344       -1
Flag Coverage Δ
unittest 90.66% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ript-estree/src/create-program/describeFilePath.ts 100.00% <0.00%> (ø)
...-estree/src/create-program/createProjectProgram.ts 97.67% <0.00%> (+4.19%) ⬆️

@bradzacher bradzacher merged commit ee707b4 into main Mar 1, 2023
@bradzacher bradzacher deleted the chore/fix-website-build-warrning branch March 1, 2023 07:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Warning in website builds
2 participants
@armano2 @bradzacher