Skip to content

feat(website): change Inaccessible + text in diff codeblocks colors #6531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2023

Conversation

kmin-jeong
Copy link
Contributor

@kmin-jeong kmin-jeong commented Feb 25, 2023

PR Checklist

Overview

@nx-cloud
Copy link

nx-cloud bot commented Feb 25, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e31f54c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 46 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @kmin-jeong!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Feb 25, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit e31f54c
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/63fa09b9fc68a90008601044
😎 Deploy Preview https://deploy-preview-6531--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@kmin-jeong kmin-jeong changed the title chore(website):Modify color to match web aim 4.5. chore(website):change color to match web aim. Feb 25, 2023
@kmin-jeong kmin-jeong changed the title chore(website):change color to match web aim. chore(website):change color to match web aim. Feb 25, 2023
@kmin-jeong kmin-jeong changed the title chore(website):change color to match web aim. - chore(website):change css color to match web aim. Feb 25, 2023
@kmin-jeong kmin-jeong changed the title - chore(website):change css color to match web aim. fix:change css color to match web aim. Feb 25, 2023
@kmin-jeong kmin-jeong changed the title fix:change css color to match web aim. feat(website): change css color to match web aim. Feb 25, 2023
@kmin-jeong kmin-jeong changed the title feat(website): change css color to match web aim. feat(website): change Inaccessible + text in diff codeblocks colors Feb 25, 2023
@armano2
Copy link
Collaborator

armano2 commented Mar 1, 2023

while looking at this I noticed that we have have misaligned colors for diff highlight

.code-block-added-line:before { /* ... */}
.code-block-removed-line::before { /* ... */ }

I think we should change it to something like this

.code-block-removed-line::before,
.code-block-added-line::before {
  content: '+';
  display: inline-block;
  width: 0px;
  position: relative;
  left: -0.7em;
}

.code-block-added-line::before {
  color: var(--token-color-inserted); /* currently #02a471 */
}

.code-block-removed-line::before {
  color: var(--token-color-deleted); /* currently red */
}

thank you for a change :)

@bradzacher bradzacher merged commit e4a0a08 into typescript-eslint:main Mar 1, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Website: Inaccessible + text in diff codeblocks
3 participants