Skip to content

fix(typescript-estree): do not call export of clearProgramCache #6540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2023
Merged

fix(typescript-estree): do not call export of clearProgramCache #6540

merged 1 commit into from
Feb 27, 2023

Conversation

sandersn
Copy link
Contributor

Calling it exports undefined instead of making it an alias of clearCaches, which I believe was the intent.

On DefinitelyTyped, I worked around the problem; clearProgramCaches isn't needed now anyway.

@sandersn
Do not call export of clearProgramCache
b964b10 
Calling it exports `undefined` instead of making it an alias of
`clearCaches`, which I believe was the intent.
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @sandersn!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloud bot commented Feb 27, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b964b10. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Feb 27, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit b964b10
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/63fd0d3678012e000826dce6
😎 Deploy Preview https://deploy-preview-6540--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

bradzacher
bradzacher reviewed Feb 27, 2023
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️ Thanks for this.

@bradzacher bradzacher changed the title Do not call export of clearProgramCache fix(typescript-estree): do not call export of clearProgramCache Feb 27, 2023
@codecov
Copy link

codecov bot commented Feb 27, 2023 •
edited
Loading

Codecov Report

Merging #6540 (b964b10) into main (678ed41) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6540   +/-   ##
=======================================
  Coverage   90.66%   90.66%           
=======================================
  Files         376      376           
  Lines       12851    12851           
  Branches     3783     3783           
=======================================
  Hits        11651    11651           
  Misses        856      856           
  Partials      344      344
Flag Coverage Δ
unittest 90.66% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/typescript-estree/src/clear-caches.ts 100.00% <100.00%> (ø)

@bradzacher bradzacher merged commit 181e705 into typescript-eslint:main Feb 27, 2023
@sandersn sandersn deleted the do-not-call-export-of-clearProgramCache branch February 27, 2023 20:36
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sandersn @bradzacher