Skip to content

chore: enable unicorn/no-typeof-undefined rule #6557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 8, 2023
Merged

chore: enable unicorn/no-typeof-undefined rule #6557

merged 2 commits into from
Mar 8, 2023

Conversation

fisker
Copy link
Contributor

@fisker fisker commented Mar 2, 2023

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @fisker!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloud bot commented Mar 2, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 19cea65. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Mar 2, 2023 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 19cea65
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/64007c73099c0300089f6b69
😎 Deploy Preview https://deploy-preview-6557--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@fisker fisker changed the title style: enable unicorn/no-typeof-undefined style: enable unicorn/no-typeof-undefined rule Mar 2, 2023
@fisker fisker changed the title style: enable unicorn/no-typeof-undefined rule chore: enable unicorn/no-typeof-undefined rule Mar 2, 2023
@codecov
Copy link

codecov bot commented Mar 2, 2023 •
edited
Loading

Codecov Report

Merging #6557 (f5f9b49) into main (ba2f0c5) will not change coverage.
The diff coverage is 80.00%.

❗ Current head f5f9b49 differs from pull request most recent head 19cea65. Consider uploading reports for the commit 19cea65 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6557   +/-   ##
=======================================
  Coverage   90.66%   90.66%           
=======================================
  Files         376      376           
  Lines       12851    12851           
  Branches     3783     3783           
=======================================
  Hits        11651    11651           
  Misses        856      856           
  Partials      344      344
Flag Coverage Δ
unittest 90.66% <80.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/eslint-plugin/src/rules/no-explicit-any.ts 96.42% <ø> (ø)
packages/type-utils/src/containsAllTypesByName.ts 0.00% <0.00%> (ø)
...slint-plugin/src/rules/no-unnecessary-qualifier.ts 100.00% <100.00%> (ø)
...es/eslint-plugin/src/rules/prefer-function-type.ts 97.18% <100.00%> (ø)

@fisker fisker force-pushed the no-typeof-undefined branch from f5f9b49 to 19cea65 Compare March 2, 2023 10:37
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯, thanks @fisker!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 0edf3b8 into typescript-eslint:main Mar 8, 2023
@fisker fisker deleted the no-typeof-undefined branch March 8, 2023 23:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Simplify typeof === 'undefined' checks
2 participants
@fisker @JoshuaKGoldberg